Implementation notes: Changes needed if we have products for natural persons

open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.

https://credere.readthedocs.io

BSD 3-Clause "New" or "Revised" License

5 stars 0 forks source link

Implementation notes: Changes needed if we have products for natural persons #372

Open yolile opened 3 months ago

yolile commented 3 months ago

When we have credit products for natural persons we will need to:

Remove the filters for not inviting natural persons at all
Restore the filter for showing credit products depending on the borrower's type (see https://github.com/open-contracting/credere-backend/pull/371)

jpmckinney commented 3 months ago

When restoring the filter 8d0ef0a we should make BorrowerBase use an enum for type. The code in that commit instead compared to a string from the CCE API, which is potentially unstable (and it means Colombia logic bleeds into the model – which it does elsewhere like "COP" defaults, but we try to limit it).