search

open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.
https://credere.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Improve email rendering in Outlook #409

Closed yolile closed 2 months ago

yolile commented 2 months ago

Apparently, the invitation email is not being rendered correctly in Outlook image

For now, we should try at least for the Credere button to look better:

image

jpmckinney commented 2 months ago

We can see if we can replicate the issue in Mailtrap (has a free tier).

yolile commented 2 months ago

Aha, also I'm using https://premailer.dialect.ca/ to at least see CSS compatibility with different email clients

yolile commented 2 months ago

For the button to be displayed properly, I think we need to replace the "display" CSS style

yolile commented 2 months ago

Weight and height attributes are also not well supported in Outlook, so I will remove them and make images smaller directly instead (note that we will need to update Cloudfront)

jpmckinney commented 2 months ago

Cool - are there any other tools you use? We can add them to the docs.

yolile commented 2 months ago

Cool - are there any other tools you use? We can add them to the docs.

That is the only one I found that solved my problem (checking what wasn't working per email client), and you do not need to register or pay for it.

yolile commented 2 months ago

Closed by https://github.com/open-contracting/credere-backend/commit/9dc088d6fd42de2255d5025adbf88d9d16a77790

yolile commented 2 months ago

And https://github.com/open-contracting/credere-frontend/commit/61d879386541fb7379ea2444b8781eac1d80019f in the front end (already invalidated the cache in CloudFront too)