search

open-contracting / credere-backend

A tool that facilitates the participation of Micro, Small, and Medium businesses (MSMEs) in the Colombian public procurement market.
https://credere.readthedocs.io
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Additional comments logic #412

Closed jpmckinney closed 1 week ago

jpmckinney commented 1 week ago

https://github.com/open-contracting/credere-backend/blob/097c31de0bdfd00d19a779de5ffc9711453290e9/app/mail.py#L82-L90

This means that if the lender has a default_pre_approval_message, then they can never send custom additional comments. Is that the intended logic, or should lenders be able to override the default?

Commit: 296f8c5ffed9d89d7ddfcf7ab9649bc50b3df6fa

yolile commented 1 week ago

Is that the intended logic

Yes, that is intentional