Closed jpmckinney closed 3 years ago
Deployed and fixed. However, I had to hack few issues in dependency checks (test_requirements.py).
@jakubkrafka Is there a reason the config file starts with test
? This can also confuse test runners.
For psycopg2-binary, you can change the command to run with STANDARD_MAINTENANCE_SCRIPTS_IGNORE=psycopg2 pytest /tmp/test_requirements.py
In test_requirements.py
, we already look in configurations for INSTALLED_APPS
, etc. so I can also update it so that STANDARD_MAINTENANCE_SCRIPTS_IGNORE
is not needed in future.
Aha, test.py
was a settings file for the CI environment. I guess github.py
is fine, or ci.py
.
Thanks for the script update! I've considered the ignore as well, but didn't like it in the end. The test for such a crucial component should be present. B
Added vue CI to the process as well.
As a Django project, this can copy the workflows from one of toucan, kingfisher-process (django branch), cove-ocds, cove-oc4ids, etc. I've enabled Coveralls, so Coveralls reporting should just work once CI is set up.
Also, please add a readme with the badges for CI and Coveralls.