search

open-contracting / european-union-support

Support scripts for TED mapping
BSD 3-Clause "New" or "Revised" License
9 stars 3 forks source link

eForms SDK 1.12.0 #215

Closed jpmckinney closed 1 week ago

jpmckinney commented 3 months ago

https://github.com/OP-TED/eForms-SDK/releases/tag/1.12.0

1.11 was #204

I haven't had a chance to review, but my typical process is to start a branch, run the "Upgrade SDK version" steps, and document changes here, like in #204 and earlier.

odscjen commented 3 months ago

Relevant

Business terms removed:

New Business terms added

Maybe relevant

Codelist values now listed rather than just naming the codelist:

type 'id' now type 'id-ref' with list of 'idSchemes'

No longer mandatory

Conditional mandatory

Now mandatory

Codelist name change

Change in xpathAbsolute

Not relevant

New 'businessEntityID' added to all business terms

New 'referencedBusinessEntityIds' field

odscjen commented 3 months ago

I'll review the changes for relevance and add the new guidance etc later this week

jpmckinney commented 3 months ago

I updated the instructions with a step to update drop (to ignore any irrelevant new properties like businessEntityId and referencedBusinessEntityIds), and I re-did the commit, to make the diff smaller. Please git pull. If you get merge conflicts, you can either (1) abandon the pull, git reset to a known good commit, then pull or (2) delete your local repository and start over (this assumes you have no local branches).

I also did this step:

Fields removed from source/fields.json remain in output/mapping/eforms/guidance.yaml with only eForms guidance, eForms example, OCDS example and sdk fields. Remove such fields manually.

The diff is a manageable size now: https://github.com/open-contracting/european-union-support/commit/045a51bfad8c508f706ed11e848d28fbc3dad69a

odscjen commented 3 months ago

edit - moved this comment to new issue https://github.com/open-contracting/european-union-support/issues/219

odscjen commented 3 months ago

Review results

Codelist name changes - no updates needed

Business terms removed - BT-747 and BT-749 are both referenced in mappings that affect the same SelectionCriteria objects. These references will need to be removed and likely replaced with references to BT-806, BT-809, BT-821 (still to create mappings for these new fields)

type 'id' now type 'id-ref' with list of 'idSchemes' - no changes needed, just placing constraints on the id code pattern for the publisher when they're creating their eForm but OCDS doesn't enforce similar constraints on the id fields being mapped to

mandatory changes - no changes needed to OCDS mapping

xpath changes

I'll apply the listed changes as part of a PR to update the mappings once they've been agreed

odscjen commented 3 months ago

moved this comment to new issue https://github.com/open-contracting/european-union-support/issues/220

odscjen commented 3 months ago

sorry I didn't think they were all going to be so big and I should have started new issues for them. I've done so for the final new field https://github.com/open-contracting/european-union-support/issues/218 and moved the others into their own issues