Closed duncandewhurst closed 1 hour ago
Just checking what makes this PR a draft?
Totals | |
---|---|
Change from base Build 11595304343: | 0.0% |
Covered Lines: | 426 |
Relevant Lines: | 445 |
Oops, I somehow missed the notification about your comment. Sorry!
It was draft because I needed to resolve the pytest failure. I've done that now.
As well as integrating the content from how the extensions work I think that we should also integrate the content from codelists. Otherwise, the explanations of schema extensions and codelist extensions will be in different places. I've rewritten the codelist explanation to follow the same style as the schema guidance:
An extension's codelist CSV files follow the structure of the OCDS codelist files and describe new codelists and codes. To add a new codelist, ensure that your filename does not clash with any existing codelist filenames. To add codes to an existing codelist, name your file
+<codelist filename>.csv
and ensure that the new codes do not clash with any existing codes. For example, to add 'subcontractor' topartyRole.csv
, add a file named+partyRole.csv
to thecodelists
directory and set its content to:Code,Title,Description subcontractor,Subcontractor,An organization that will perform part of a contract on behalf of a supplier.
Shall I add that to this PR?
Oh, I forgot that https://github.com/open-contracting/standard_extension_template/issues/41 is about moving all the content. I may as well do it all in this PR, but I'll prepare a draft in Google Docs before updating the HTML templates.
Logging the steps I followed so far, for posterity:
<h4>
tags: find <h4>(.*?)</h4>
and replace with <h4>{{ _("$1") }}</h4>
href="(.*?)"
and replace with href='$1'
<code>
tags (manual)<pre>
and <code>
tags and remove any HTML and translation tags within the block
and
characters’
) with single quotation marks ('
)<p></p>
<a href=(.*?)> </a>
and replace with
(might get some false positives)To-do:
id
parameters and relative link targets@jpmckinney the lint check is failing because ruff reports errors on Python files not touched by this PR.
Needed to merge main
.
Ah, I forgot this was an old branch. Thanks!
Leaving as draft pending further input on the needs of extension authors in https://github.com/open-contracting/standard_extension_template/issues/41. Otherwise, this is ready for review.
I think we might as well get this PR done and make other changes/improvements later.
@yolile I pushed strings to Transifex: https://app.transifex.com/open-contracting-partnership-1/ocds-extension-explorer/translate/#es/messages/306008985
Translated
Closes https://github.com/open-contracting/standard_extension_template/issues/41