Closed odscjames closed 6 years ago
@odscjames Assuming you used code to generate this, can you instead put the values in a Google Spreadsheet, and I can then perhaps highlight in green the values to retain? In many cases I prefer the extension (typo correction, etc.), but in some cases we'll need discussion.
Done - I will email you an edit invite.
For other people to view, it is at: https://docs.google.com/spreadsheets/d/1wod1k4FGzBf0wTECn4ZfEoGcZ7CYXdzkOGTFG_P3WzU/edit?usp=sharing
@duncandewhurst The names and descriptions in the extension registry and extensions have drifted. Going forward, the extension registry will not have a duplicate copy of the name or description, to avoid drift. Can you have a look at the spreadsheet above, and select which to use in extensions? I did a very quick pass for the most obvious. Also, feel free to add a third option if neither is good (e.g. OCDS for PPPs
instead of OCDS for PPPs (Alpha)
).
Note our guidance on extension descriptions.
We should also use Title Case for extension names (and update the extension template to say so, and any extensions as appropriate).
I've highlighted the preferred options in green in the spreadsheet.
I added Name New
, Description New
and Documentation URL New
columns and tried to update descriptions in line with the guidance where necessary.
@jpmckinney I left a couple of comments for your attention re: PPPs
Ran out of time for now; done up to and including PPP. If you look at the GitHub issue you should see links.
I think that's it - check all the P.R.'s linked from this issue.
Thanks! I'm doing some focused work this week, so I'll review in the next couple weeks.
All merged, thanks!
As discussed on #90, we are going to de-duplicate values between the extension_registry and the repository for each extension. Below is a report in the differences between the 2 sides (master branch in both cases).
The report covers name, description and documentation fields. We are however ignoring most differences in the documentation field as most of them are simply a "/" or a "/blob/master/README.md" at the end so fundamentally they point to the same place anyway. The one exception is below.
It is noted that in the past, for these 3 fields, the value from the Registry would have been used. Therefore it might be that the easy answer to this is "in each case, use the values from the registry". But this should be read to double check.
I can make the changes if someone confirms to me what changes should be made.
Id: signatories
Please make https://github.com/open-contracting/ocds_contract_signatories_extension/blob/master/extension.json have the correct value
Id: documentation
Please make https://github.com/open-contracting/ocds_documentation_extension/blob/master/extension.json have the correct value
Id: transactions_relatedMilestones
Please make https://github.com/open-contracting/ocds_transactions_relatedMilestone_extension/blob/master/extension.json have the correct value
Id: extendsContractID
Please make https://github.com/open-contracting/ocds_extendsContractID_extension/blob/master/extension.json have the correct value
Id: requirements
Please make https://github.com/open-contracting/ocds_requirements_extension/blob/master/extension.json have the correct value
Id: tariffs
Please make https://github.com/open-contracting/ocds_tariffs_extension/blob/master/extension.json have the correct value
Id: performance_failures
Please make https://github.com/open-contracting/ocds_performance_failures/blob/master/extension.json have the correct value
Id: additionalContactPoint
Please make https://github.com/open-contracting/ocds_additionalContactPoints_extension/blob/master/extension.json have the correct value
Id: location
Please make https://github.com/open-contracting/ocds_location_extension/blob/master/extension.json have the correct value
Id: risk_allocation
Please make https://github.com/open-contracting/ocds-riskAllocation-extension/blob/master/extension.json have the correct value
Id: qualification
Please make https://github.com/open-contracting/ocds_qualification_extension/blob/master/extension.json have the correct value
Id: partyScale
Please make https://github.com/open-contracting/ocds_partyDetails_scale_extension/blob/master/extension.json have the correct value
Id: charges
Please make https://github.com/open-contracting/ocds_charges_extension/blob/master/extension.json have the correct value
Id: shareholders
Please make https://github.com/open-contracting/ocds-shareholders-extension/blob/master/extension.json have the correct value
Id: budgets_and_projects
Please make https://github.com/open-contracting/ocds_budget_projects_extension/blob/master/extension.json have the correct value
Id: metrics
Please make https://github.com/open-contracting/ocds_metrics_extension/blob/master/extension.json have the correct value
Id: ppp
Please make https://github.com/open-contracting/public-private-partnerships/blob/master/extension.json have the correct value
Id: buyer_per_contract
Please make https://github.com/open-contracting/ocds_multiple_buyers_extension/blob/master/extension.json have the correct value
Id: finance
Please make https://github.com/open-contracting/ocds_finance_extension/blob/master/extension.json have the correct value
Id: budget_breakdown
Please make https://github.com/open-contracting/ocds_budget_breakdown_extension/blob/master/extension.json have the correct value