open-contracting / field-level-mapping-template

Collects issues for the improvement and generation of the Field-Level Mapping Template.
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Update schema tab with the latest version #27

Open Ravf95 opened 1 year ago

Ravf95 commented 1 year ago

The mapping template schema tab contains unchecked deprecated fields, also the reference links are invalid

I've found that these fields are deprecated

buyer/additionalIdentifiers
contracts/implementation/transactions/payee/additionalIdentifiers
contracts/implementation/transactions/payer/additionalIdentifiers
tender/procuringEntity/additionalIdentifiers
tender/tenderers/additionalIdentifiers
contracts/implementation/milestones/documents
contracts/milestones/documents
planning/milestones/documents
tender/milestones/documents
contracts/implementation/milestones/documents

Some examples of invalid links

cc @jpmckinney @yolile

jpmckinney commented 1 year ago

No need to cc. I always receive all issues on all repositories.

jpmckinney commented 1 year ago

Feel free to author a PR.

yolile commented 1 year ago

For more context about the issue of the depreacted objects: image Only the object is not marked as deprecated, and I think this issue will be harder to resolve, as the object itself is not deprecated, only the reference in buyer, etc.

And for the links, the issue is in https://github.com/open-contracting/field-level-mapping-template/blob/b538edd1e4f666063ec9d58759c1e6f4222c7989/mapping_template_sheets.py#L113 where we explicitly set the URL to 1.1.5. I guess we need to set this to 1.1 instead (not sure if these links ever worked).

jpmckinney commented 1 year ago

Patches might have worked back when staging branches were not namespaced by /staging/. However, these URLs should never have been constructed this way, as staging branches are temporary.

jpmckinney commented 1 year ago

OCDS Kit generates a mapping sheet in which buyer/additionalIdentifiers has 1.1 in the deprecated column. It looks like this notebook isn't using OCDS Kit's mapping_sheet() – it should.