Open Ravf95 opened 1 year ago
No need to cc. I always receive all issues on all repositories.
Feel free to author a PR.
For more context about the issue of the depreacted objects:
Only the object is not marked as deprecated, and I think this issue will be harder to resolve, as the object itself is not deprecated, only the reference in buyer
, etc.
And for the links, the issue is in https://github.com/open-contracting/field-level-mapping-template/blob/b538edd1e4f666063ec9d58759c1e6f4222c7989/mapping_template_sheets.py#L113 where we explicitly set the URL to 1.1.5. I guess we need to set this to 1.1 instead (not sure if these links ever worked).
Patches might have worked back when staging branches were not namespaced by /staging/
. However, these URLs should never have been constructed this way, as staging branches are temporary.
OCDS Kit generates a mapping sheet in which buyer/additionalIdentifiers
has 1.1
in the deprecated
column. It looks like this notebook isn't using OCDS Kit's mapping_sheet() – it should.
The mapping template schema tab contains unchecked deprecated fields, also the reference links are invalid
I've found that these fields are deprecated
Some examples of invalid links
cc @jpmckinney @yolile