open-contracting / kingfisher-collect

Downloads OCDS data and stores it on disk
https://kingfisher-collect.readthedocs.io
BSD 3-Clause "New" or "Revised" License
13 stars 12 forks source link

Environment variable for spiders needing proxy #1085

Open jpmckinney opened 4 months ago

jpmckinney commented 4 months ago

I hardcoded Montreal as using a proxy. Since the need for a proxy depends on the server, we can instead implement the list of spiders needing a proxy as an environment variable, and configure the custom settings on the base spider.

Would need to look into how/when Scrapy reads the custom_settings class attribute, as we’ll want subclasses to be able to add to it.