open-contracting / kingfisher-collect

Downloads OCDS data and stores it on disk
https://kingfisher-collect.readthedocs.io
BSD 3-Clause "New" or "Revised" License
13 stars 12 forks source link

dominican_republic_api: Date with no data should not return 404 #1086

Closed jpmckinney closed 4 months ago

jpmckinney commented 4 months ago

This is an API implementation issue, but we can handle it on the client side.

e.g. https://api.dgcp.gob.do/api/date/2023-12-17/2023-12-18/1 has no results. But, that should just be an empty package (a.k.a. no results). Not a 404. In general, search interfaces do not return 404 when there are no results. This is covered at https://standard.open-contracting.org/latest/en/guidance/build/hosting/#response-format

jpmckinney commented 4 months ago

Another API implementation issue: Next links should not be provided if there is no next page i.e. the next page is empty. e.g. https://api.dgcp.gob.do/api/date/2023-08-23/2023-08-24/1 links to https://api.dgcp.gob.do/api/date/2023-08-23/2023-08-24/2?limit=100