open-contracting / kingfisher-summarize

Creates SQL tables that summarize the OCDS data in collections from Kingfisher Process
https://kingfisher-summarize.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

parties_id should be renamed #204

Closed jpmckinney closed 3 years ago

jpmckinney commented 3 years ago

In #196, supplier_parties_id became supplier_id, but buyer_parties_id, procuringentity_parties_id and tenderer_parties_id became parties_id. They should all follow the pattern of buyer_id, etc. since the SQL is taking the value from the buyer object, not from the parties object. The remaining parties_id in parties_summary should probably be party_id instead.