search

open-contracting / kingfisher-summarize

Creates SQL tables that summarize the OCDS data in collections from Kingfisher Process
https://kingfisher-summarize.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

manage.py: Add a --filter option to the CLI #215

Closed Bjwebb closed 3 years ago

Bjwebb commented 3 years ago

A period separated argument is converted into the a '->' separated clause needed for postgres' JSON.

https://github.com/open-contracting/kingfisher-summarize/issues/190

To do:

Bjwebb commented 3 years ago

@jpmckinney What do you think of the simple string replace used here for the where clause? Is this sufficient for now, or should we have more serious templating (e.g. jinja) here?

jpmckinney commented 3 years ago

@jpmckinney What do you think of the simple string replace used here for the where clause? Is this sufficient for now, or should we have more serious templating (e.g. jinja) here?

I think it's fine - especially if my suggestion to change it to -- WHERE_FRAGMENT is applied.

Bjwebb commented 3 years ago

@jpmckinney I'm not sure what's happening with pre-commit.ci for this repo.