Closed Bjwebb closed 2 years ago
@jpmckinney What do you think of the simple string replace used here for the where clause? Is this sufficient for now, or should we have more serious templating (e.g. jinja) here?
@jpmckinney What do you think of the simple string replace used here for the where clause? Is this sufficient for now, or should we have more serious templating (e.g. jinja) here?
I think it's fine - especially if my suggestion to change it to -- WHERE_FRAGMENT
is applied.
@jpmckinney I'm not sure what's happening with pre-commit.ci for this repo.
A period separated argument is converted into the a '->' separated clause needed for postgres' JSON.
https://github.com/open-contracting/kingfisher-summarize/issues/190
To do: