open-contracting / lib-cove-ocds

A data review library for the Open Contracting Data Standard (OCDS)
Other
0 stars 0 forks source link

Additional check: Releases with same date for given ocid #90

Open ColinMaudry opened 3 years ago

ColinMaudry commented 3 years ago

If two releases or more with the same ocid and date, should the tool return a warning?

Follow up of https://github.com/open-contracting/standard/issues/848

cc @duncandewhurst @jpmckinney

jpmckinney commented 3 years ago

We could do this check here. We have similar uniqueness checks, so it should not be difficult to add. However, implementers only upload one package at a time, and this issue is maybe more likely to occur within a full dataset, rather than in a sample.

duncandewhurst commented 3 years ago

Publishers sometimes mistakenly set date in each release to the date the whole package was generated, so it would be useful to include this check, even at the package level.

jpmckinney commented 3 years ago

Makes sense!