search

open-contracting / oc4idskit

A suite of command-line tools for working with OC4IDS data
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

convert-from-ocds: expand procuring_entity function #1

Open pindec opened 3 years ago

pindec commented 3 years ago

The current procuring_entity function only copies across parties with a role of "procuringEntity".

It should also check whether tender.procuringEntity.name and tender.procuringEntity.id exist as outlined in the mapping to cover cases where tender.procuringEntity fields are declared, but the roles for that party do not include "procuringEntity", as in the OCDS sample data.

https://github.com/open-contracting/ocdskit/blob/9255880b2e5bda334b4e0e61cd5ecc327aab3c5f/ocdskit/oc4ids.py#L392

duncandewhurst commented 3 years ago

@pindec please could you open an issue on the sample data repo to add the 'procuringEntity' role.