I'm curious why the design is to loop over the compiled releases in each transform? It seems less efficient than just doing that once.
Given that each transform calls run in __init__, it's not clear to me that a system of multiple classes is simpler than a single class (to maintain any global state) with one method for each transform (e.g. if the OCDS upgrade methods needed to maintain state between transforms, we could just put them all under one big class).
jpmckinney
commented
4 years ago
Copying from https://github.com/open-contracting/ocdskit/commit/f703eb9d9e1fc643f680232fe32cd5d9c302a4e5
I'm curious why the design is to loop over the compiled releases in each transform? It seems less efficient than just doing that once.
Given that each transform calls
runin__init__, it's not clear to me that a system of multiple classes is simpler than a single class (to maintain any global state) with one method for each transform (e.g. if the OCDS upgrade methods needed to maintain state between transforms, we could just put them all under one big class).