Closed kindly closed 4 years ago
For planning/project/sector
- since this is an array, I would prefer to add the sectors from all contracting processes.
Otherwise all sounds good.
Sector now gets unique scheme-id strings from all contracting processes.
The solutions seem reasonable to me. @duncandewhurst If you agree, then I think this issue can be closed?
All good!
There are a few areas in the OCDS -> OC4IDS conversion where what to do with data across different contracting processes is not currently clearly defined. I do not think there is a perfect solution to these but below outlines what the current implementation does so that we can discuss other potential solutions.
planning/project/title, project/planning/description (planning and budget extension)
If there are any contradictions i.e one contract says the title is different from another a warning is raised and the field is ignored in that case. If all contracting processes agree (when the fields exists in them) then the value is still used.
tender/title, tender/description, /planning/rationale
If there a multiple contradicting process then we concatenate the strings and put the ocid in angle brackets like
If there is only one contracting processes then the ocid part is omitted.
parties
We need to deal with
party/id
from different contracting processes conflicting and also if there are parties in multiple contracting processes that are the same, we should treat them as the same party.Current logic:
identifier
field and if there arescheme
andid
make an id ofsomescheme-someid
and use that in order to match parties across processes. If there are different roles then add them to the same party. Use the other fields from the first party found with this id.identifier
then make up a new auto increment number and use that as theid
.identifer
and all fields apart fromroles
andid
are the same across parties then treat that as a single party and add the roles together and use a single generatedid
docs
If there are are only unique project/documents/id keep the ids the same. Otherwise create a new auto-increment for all docs.