Make schema-strict for all fields

open-contracting / ocdskit

A suite of command-line tools for working with OCDS data

https://ocdskit.readthedocs.io

BSD 3-Clause "New" or "Revised" License

17 stars 7 forks source link

Make schema-strict for all fields #139

Closed romifz closed 4 years ago

romifz commented 4 years ago

Ref https://github.com/open-contracting/ocds-extensions/issues/102

I left the string type conditions as they are, I hope that's OK.

jpmckinney commented 4 years ago

Looks good!

Yes, I think the idea is that minLength becomes redundant if enum, format or pattern are present. A JSON Schema validator would report an extra message that is less useful to the user.

I'm re-running the tests as I don't see what the issue could be.

jpmckinney commented 4 years ago

I've now run this against all non-core extensions. Thanks!