search

open-contracting / ocdskit

A suite of command-line tools for working with OCDS data
https://ocdskit.readthedocs.io
BSD 3-Clause "New" or "Revised" License
17 stars 6 forks source link

Packages fail validation - no "version" key and "publishedDate" key given as "published_date" #140

Closed pindec closed 4 years ago

pindec commented 4 years ago

While using convert-to-oc4ids on the command line with --all-transforms and --package options set, I noticed that the resulting project package data fails validation.

This seems like an issue in the base packager.

Looks like the published date key is incorrect in base.py parse_package_arguments (should be "publishedDate").

Can we also have an argument in add_package_arguments to add "version"?

jpmckinney commented 4 years ago

The issue is specific to convert-to-oc4ids (other commands output publishedDate correctly). I'll have a look.

jpmckinney commented 4 years ago

Fixed. I'll make a new release shortly. version is now automatically set to 0.9 for OC4IDs, but this can be overridden with --version.

jpmckinney commented 4 years ago

0.2.7 is released. Thanks for reporting!