mapping-sheet: Updates to template generation

open-contracting / ocdskit

A suite of command-line tools for working with OCDS data

https://ocdskit.readthedocs.io

BSD 3-Clause "New" or "Revised" License

17 stars 7 forks source link

mapping-sheet: Updates to template generation #64

Closed timgdavies closed 5 years ago

timgdavies commented 5 years ago

I made the following updates in using ocdskit with a different schema (Social Economy Data Spec), to handle some particular cases there.

In particular, this:

Makes sure codelist options are displayed when the enum is within the items of an array
Displays the regular expression used when validation is against a pattern
Handles when $ref does not override titles and descriptions

timgdavies commented 5 years ago

More context:

This is not import to merge for OCDS, as for SEDL I'll work from my branch for the time being.

However, I thought useful to flag @odscjames awareness as this might also have relevance to the bodskit and ref resolving work you are doing.

I don't think this should harm OCDS mapping template generation, though I notice it has failed a test, so would probably need more investigation before a merge.

jpmckinney commented 5 years ago

FYI, @duncandewhurst @Bjwebb to optionally review output, given recent work on this command in #42

Test failure is simply due to expected output having changed (as expected due to code changes).

jpmckinney commented 5 years ago

Since there are now conflicts, I copied the changes in other commits.