search

open-contracting / ocdskit

A suite of command-line tools for working with OCDS data
https://ocdskit.readthedocs.io
BSD 3-Clause "New" or "Revised" License
17 stars 7 forks source link

[#79] make_versioned_release make_compiled_release library functions. #80

Closed kindly closed 5 years ago

kindly commented 5 years ago

Add functions so they can be used as a library.

kindly commented 5 years ago

The tests are failing as this only works with the 'dev' branch on ocdsmerge.

This will not work on the pypi version on ocdsmerge due to it not accepting merge_rules as an argument.

@jpmckinney I can make the tests work on the master branch of ocdsmerge and make a pypi realease for that? or shall we wait for the 'dev' branch to be finished?

jpmckinney commented 5 years ago

I have a few notes of things I want to finish on the dev branch. I'll see if I can do those tomorrow.

jpmckinney commented 5 years ago

I've merged the dev branch of ocds-merge, but I want to update the readme before making a release.

jpmckinney commented 5 years ago

OCDS Merge 0.5 is released. I'll look at this now.

jpmckinney commented 5 years ago

This conflicts with some changes I made while preparing OCDS Merge 0.5.

However, looking at the implementation in this PR, it looks like Kingfisher would have to take responsibility for collecting releases by OCID, and then calling make_compiled_release or make_versioned_release, which are very thin wrappers around OCDS Merge. If Kingfisher is taking responsibility for the only new feature that OCDS Kit provides, then it makes more sense for Kingfisher to just call OCDS Merge directly.

Closing as a new PR would be required anyhow to avoid the new merge conflicts.