open-contracting / software-development-handbook

A guide for developers of OCP's tools
https://ocp-software-handbook.readthedocs.io/en/latest/
Other
4 stars 1 forks source link

Consider switching to hatch from setuptools #82

Closed jpmckinney closed 1 year ago

jpmckinney commented 1 year ago

hatch is now what is recommended at https://packaging.python.org/en/latest/tutorials/packaging-projects/ See documentation on migration.

We don't have any problems with setuptools, and the only setuptools-specific artifact is MANIFEST.in and the check-manifest CI check. (I suppose also setup.cfg, but we can merge that into pyproject.toml. *)

I don't know if hatch has something like check-manifest.

* It looks like having only a pyproject.toml file can cause issues (see flake8 comment, which is linked from the last comment in that issue, which links to a closed black issue, which links to open pip issues, of which there are many related to PEP 517).

We might not encounter any of the open issues in our projects... but there also seems to be little benefit to switching.

See also discussion about Flit in #62.

jpmckinney commented 1 year ago

Closing as we'll stick with setuptools for now. We might switch if there is a stronger trend away from setuptools.