search

open-contracting / standard-maintenance-scripts

Scripts for maintaining all repositories, in particular the standard's documentation and extensions
https://open-contracting.github.io/standard-maintenance-scripts/
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Remove unused "version" field from extension-schema.json #98

Closed jpmckinney closed 6 years ago

jpmckinney commented 6 years ago

See earlier discussion in #97

timgdavies commented 6 years ago

Unless there is a rush to remove this, please don't merge until I've had time to fully review updates to extension handling.

jpmckinney commented 6 years ago

Sure - though there have been no changes to extensions, only to the registry. All significant changes to extensions would occur in the extension template. This repo is just centralized but non-authoritative testing and maintenance scripts.

jpmckinney commented 6 years ago

If you're thinking of looking at everything, I prepared this reference page to show the inter-dependencies https://github.com/open-contracting/standard-maintenance-scripts/blob/master/schema/README.md

jpmckinney commented 6 years ago

@timgdavies Do you still plan to fully review updates to extension handling before discussing this PR, and if so, when do you expect to be able to comment on this PR?

We can always re-add a version field once we've decided and are ready to implement one. I don't see a downside to removing it, but I see a downside to keeping it (confusion, miscommunication, etc.).