open-contracting / standard-maintenance-scripts

Scripts for maintaining all repositories, in particular the standard's documentation and extensions
https://open-contracting.github.io/standard-maintenance-scripts/
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Add "schemas" to extension-schema.json #99

Closed jpmckinney closed 6 years ago

jpmckinney commented 6 years ago

This issue is motivated by the following:

  1. It is not possible for a service to determine which core schema files an extension patches without testing all three possible URLs (http…/release-schema.json, etc.)
  2. We would like it to be possible for a service to determine which core schema files an extension patches without doing this sort of URL discovery
  3. JSON Schema Patch files in extensions are optional (see https://github.com/open-contracting/standard_extension_template/issues/29)
  4. We would like CoVE to display an appropriate error if an explicitly expected patch file is missing, but not error otherwise

As background:

If this issue is agreed, I can merge this and then use the local:extension_json task it contains to update all extension repositories, as I've done in the past for other changes to all extensions.

Requesting review from one of @duncandewhurst @kindly @timgdavies

jpmckinney commented 6 years ago

Related issue: https://github.com/OpenDataServices/cove/issues/1024

jpmckinney commented 6 years ago

@duncandewhurst @kindly @timgdavies As this may have an impact on the extension explorer, could one of you review by end of next week? cc @robredpath

duncandewhurst commented 6 years ago

Discussed with @kindly and this is OK to be merged.