search

open-contracting / standard

Documentation of the Open Contracting Data Standard (OCDS)
http://standard.open-contracting.org/
Other
139 stars 46 forks source link

Move unit to definitions #1107

Closed duncandewhurst closed 2 years ago

duncandewhurst commented 4 years ago

unit is currently defined as a property of Item.

The metrics extension repeats the definition and Moldova's eOCDS-eAuction extension will do the same.

It would be better to have a definition for unit which can be referenced by extensions.

Proposal

  1. Move the definition of unit to the definitions section of the schema.
  2. Update the metrics extension to reference the definition, rather than repeat it.

cc @PaulBoroday

jpmckinney commented 4 years ago

Agreed. This is a simple refactor of the schema.

jpmckinney commented 3 years ago

@yolile for the metrics extension, we can rename master to 1.1 (and update the registry), and then add a 1.2 branch that references the Unit definition.

yolile commented 2 years ago

Closing in favor of https://github.com/open-contracting/ocds-extensions/issues/179 as the part related to the schema was done in #1240