open-contracting / standard

Documentation of the Open Contracting Data Standard (OCDS)
http://standard.open-contracting.org/
Other
138 stars 46 forks source link

Merge stable extensions into the standard #1179

Open yolile opened 3 years ago

yolile commented 3 years ago

Discussion

From https://github.com/open-contracting/standard/issues/891#issuecomment-693634519:

Adding more extensions to core would be good – extensions have issues as described here. A simple example is that there is no probability of two EU publishers choosing the correct/same combination of extensions for sub-threshold procedures.

We should analyze and consider which current and widely used extensions should be added to the standard itself.

One of these extensions could be Bid statistics and details extension. This information is important because as the extension itself mentions:

Information on bids submitted as part of a contracting process is important for many forms of analysis, including:

  • Market analysis for understanding the competitiveness of a given marketplace;
  • Red flag analysis for understanding potential corruption risks; and
  • Value for money analysis;

This information is available at least in:

jpmckinney commented 3 years ago

Also related: #1183

duncandewhurst commented 2 years ago

Since the implementation research is more than a year old now, I used the OCDS Downloads stats to generate a report of extension usage by publisher.

I used the Domain metadata from the Kingfisher Collect spiders to identify the publisher, to avoid counting different endpoints for the same publication, e.g. HondurasPortalBulk, HondurasPortalRecords and HondurasPortalReleases. I also counted the following domains as a single publication:

Some extensions are declared a different URLs, so I grouped the results by name.en from extension.json, where available:

The following extensions are used by more than 2 more publishers:

extension_name publisher_count_deduped
Location 8
Budget Breakdown 7
Lots 6
Bid statistics and details 5
Status Details 4
Member Of 3
Contract suppliers 3
Guarantees 3
Additional Contact Points 3

We already plan to move some of these extensions to the standard in 1.2:

There are issues with some of the other extensions:

Otherwise, Location, Budget Breakdown, Bid statistics and details, and Additional Contact Points seem like good candidates to move to the schema.

Many other extensions are used by 2 publishers, but I'm assuming we wouldn't consider that to be 'widely' used.

Edit: A handful of publishers were not included in this analysis because there were issues scraping their data:

If I remember correctly, Paraguay is a heavy user of extensions, so we might want to add their extensions to the total above.

duncandewhurst commented 2 years ago

@jpmckinney @yolile based on the above, are you happy for me to start on preparing PRs to merge the following extensions?

yolile commented 2 years ago

If I remember correctly, Paraguay is a heavy user of extensions, so we might want to add their extensions to the total above.

From the >=3 list, Paraguay will add 1 to Lots, Budget Breakdown and Bid statistics and details (and an additional extension over that one to include items, see https://github.com/open-contracting/ocds-extensions/issues/126)

Many other extensions are used by 2 publishers, but I'm assuming we wouldn't consider that to be 'widely' used.

From the = 2 list, Paraguay will add 1 to Item attributes, Enquiries, Budget and spending classification and Parties scale. We could consider adding these too if the criteria is >= 3.

But happy to start with the ones that are used for more than 3

jpmckinney commented 2 years ago

Contract suppliers - @jpmckinney I seem to remember you had some concerns about this extension, but I can't find the issue in which you described them

https://github.com/open-contracting/ocds-extensions/issues/86#issuecomment-510542416

4+

<=3

FYI, OCDS Downloads hasn't set the API keys for OpenOpps and Paraguay – so it can't collect their data.

duncandewhurst commented 2 years ago
  • Location has some open issues to review. It has geographically-diverse adoption. It seems like a good candidate.

I reviewed the open extensions. https://github.com/open-contracting/ocds-extensions/issues/173 and https://github.com/open-contracting/ocds-extensions/issues/115 seem ready to address at the same time as merging the extension. https://github.com/open-contracting/ocds-extensions/issues/142 is more about the Address object and it looks like consensus wasn't yet achieved, but I don't think it blocks merging the extension. The other issues are unrelated. Are you happy to go ahead with merging the extension on that basis?

duncandewhurst commented 2 years ago

Additional Contact Points: It's only Mexico (multiple) and Moldova. What are the additional contact types for those publishers?

Of the publications that declare the extension, only Mexico SHCP actually publishes parties.additionalContactPoints. The additional contact points are just a list of individual names, so I can't tell the 'type' from the data. In any case, since only one publisher actually uses the extension's fields, I suggest we don't need to merge the extension into the standard.

jpmckinney commented 2 years ago

Are you happy to go ahead with merging the extension on that basis?

Let's make a PR against the Location extension first. That way, we can release a 1.1.6 of that extension to be in sync with the version that is merged to OCDS 1.2.0.

duncandewhurst commented 2 years ago

The Bids extension has many open issues. We need to review whether they are still valid and whether they need to be addressed before inclusion.

I've reviewed and commented on the open issues. Some require further discussion.

yolile commented 2 years ago

Should we consider adding the organization classification extension as well? As there have been requests from different partners on how to disclose gender info in OCDS.

jpmckinney commented 2 years ago

Sure!

jpmckinney commented 1 year ago

Noting that, if we merge bids into OCDS, we probably want awards to refer to bids (which contains tenderers / suppliers), since a principle is to only have one way to model a given concept. (I think it's also more correct that a bid is successful, rather than a specific supplier is awarded.)

jpmckinney commented 1 year ago

I opened a new issue for merging organization classification #1622. Location is covered in #1484.

The remaining candidate is Bids, but like Lots #891, there are some outstanding (and significant) issues to address e.g. https://github.com/open-contracting/ocds-extensions/issues/125, over which it will be difficult to achieve consensus.

Postponing bids (and any future candidates) to 1.3/2.0.