Open duncandewhurst opened 1 year ago
Suggest also
value
object: new description and amountNet
and amountGross
https://github.com/open-contracting/standard/pull/1519As an initial suggestion for how we should tackle this how about we:
This would have the benefit of enabling publishers who are switching to 1.2 to find the key differences in one place with appropriate explanation, and it would be in similar formatting to the rest of the docs. As it's all together it also means it can eventually be removed once enough publishers have made the switch to 1.2? But it might also be a bit overwhelming having it all presented as one big piece?
Alternatively we could:
This would have the benefit of publishers seeing the bits they need if they were checking the docs for help with a particular field/object/stage and not being overwhelmed with changes that don't affect them. But it's also a bit hidden and would require a user to review the entire docs to find all the changes guidance.
So maybe a combination of the 2 above options would be good:
@jpmckinney @yolile what do you think?
EDIT: which ever way we go this update to the docs could be supplemented with a number of blog posts?
Project and Location extensions merging into the core https://github.com/open-contracting/standard/pull/1684
Maybe cover all the merged extensions at once.
For in-context notice of changes, the proposal is to use very brief versionadded and versionchanged admonitions #862 (which are already present in some places) to flag something as new, changed or deprecated. For in-context changes, our goal is only to notify, not to explain how to migrate. This is how pretty much all other documentation does things (mainly because, once you have even more versions, it would be a mess to explain every upgrade in-context). These admonitions should mainly appear in the Reference section. (They can maybe appear in the Guidance section, but I'm less clear where the changes are notable enough to warrant it.) If the upgrade documentation goes into more depth, the admonition can link to the relevant section of the upgrade documentation. Anyway, this piece of the work can be pursued in #862.
For upgrade documentation, some good patterns are used in:
This page would appear under History. It should all be on one page. The goal is to be succinct. After all, the current 1.2 text can be read in the rest of the documentation. The goal of upgrade documentation is limited to questions that aren't answered elsewhere like: what's changed, who does this change affect, why was the change made (if not already self-evident from reading what's changed), an example if necessary.
All that said, this issue is related to the peer review step of the governance process. We expect we'll invite some specific community members to do a full review, but for the wider, open process, we will want some engagement materials (slides, etc.) to go over the key changes.
So, for this issue, it is not yet about documenting "how to upgrade". For peer review, the goal is rough consensus, and so more room can be given to "why was the change made" (what issue is being solved). Examples are also more important, because it is much easier to grasp a change during a presentation when the change is shown visually (when people can consume information at their own pace while reading documentation, it's not necessary to have visual supports for simple changes).
This issue is about key changes, so it would not be comprehensive. We're currently at 10 bullet points, which can be somewhat grouped along the lines of this early blog post https://www.open-contracting.org/2020/10/27/ocds-1-2-what-well-be-working-on/ 10 seems like a good number – we can maybe add more, but probably not much more.
Linking back to our original process document as well: https://docs.google.com/document/d/1gITRwEi3cBp7Q86U_i2PO34bdQeIJsSZWRre1bNStJE/edit
ah ok, I had interpreted
We can use Google Docs to collaborate on engagement materials and content.
to mean we were also as part of this issue looking at the form the engagement materials and documentation content would take hence my comment. Thanks for the link to the google doc, that helps make the ask of this issue much clearer.
So the content we'd be looking for here is a summary of the key changes that can be peer reviewed by the community prior to 1.2 being published to ensure there is consensus with the proposed changes?
Are you happy for me to start drafting some slides to explain the changes listed here?
So the content we'd be looking for here is a summary of the key changes that can be peer reviewed by the community prior to 1.2 being published to ensure there is consensus with the proposed changes?
Yup!
The engagement materials could take different forms. Thinking through it: I don't think we had many participants join in calls in 2016 for OCDS 1.1. Slides are easy to digest, but sometimes can be time-consuming/finicky to prepare. A web page would be fine, too. We can just publish it somewhere temporary instead of in the standard docs, but we can write it in the same Markdown (e.g. you can draft it in a branch). A benefit of a web page is we can more easily reuse some of the content for the upgrade guide. Slides help force brevity, but we can aim to be brief on the web. What do you think?
In case useful, here is what was used in 2016 for the 1.1 upgrade:
For context, I also shared the folder for the OCDS 1.1 peer review phase. Once the governance process was done, we published https://www.open-contracting.org/resources/ocds-1-1-summary-note-version-upgrade/
Really useful to see the slide deck from 1.1 and the review feedback process.
I think it depends on whether you think the bulk of engagement will be async or through calls. Given you recall that not many people joined the 1.1 upgrade calls we should probably go with the option that will be easiest to use in an async fashion. Slides can force brevity and provide clear chunking of material but they're not as easily searchable as a webpage. The ability to create navigation headings in a webpage that can sit on the side of the page (so always visible, not just at the top) would be really useful particularly as I can imagine that there will be various stakeholders who will be primarily interested in certain changes and not others and would appreciate the ability to jump straight to those ones without having to scroll through the rest.
A webpage obviously does allow for too many words but we can just try and aim for brevity there! The structure of the first slides in the long deck is especially clear with the old version next to the new version of the schema layout and then the question being asked about them.
So yes I think we should go for the temporary webpage hosted somewhere other than the main standard docs. Rather than draft it on a branch I'll start in a google doc and once we're in agreement at least on the structure I can transfer it to a markdown file in a branch (which also gives us time to think of where that would go).
Sounds great! Feel free to share an early draft, e.g. with one key change or an outline.
Tagging @ColinMaudry in here, as Colin can also help with this content – and since he has had some time away from day-to-day issues, he might have some perspective on how to communicate the changes.
@jpmckinney a rough first draft showing the general layout and an example (which as I worked on it I realised was one of the trickier ones!) of how the actual content could be structured.
cc @ColinMaudry too
Looks good to me. I left a couple comments. It is indeed a trickier one!
Let's continue to iterate one section at a time, as we'll probably find more ways to improve the pattern for each section.
@ColinMaudry feel free to take a look when you have time.
@jpmckinney I've updated according to your comments on the first section and added a few more trying to cover a couple that I think will require a slightly different pattern.
The guidance for connecting publications is new and while it doesn't involve any schema changes it might also be good to include here similar to how we're explaining about the new guidance on how to link planning and contracting processes?
@odscjen @jpmckinney Sorry, I misconfigured my git mentions and they were lost with other notifications.
Looking at the google doc and the dev doc... 🧐
thanks @ColinMaudry just to note that there's a new copy that's the one that should be used for reviewing, https://docs.google.com/document/d/1QL3MN4Exj1xgZNbsVTGF3PHampB-D3i0BB9CkmfRMfg/edit
Let's use this issue to log key changes to socialize. We can use Google Docs to collaborate on engagement materials and content.
Based on the changelog, @jpmckinney suggested the following:
Previously, we'd also logged: