search

open-contracting / standard

Documentation of the Open Contracting Data Standard (OCDS)
http://standard.open-contracting.org/
Other
139 stars 46 forks source link

docs/schema/identifiers.md: Explain who can register an OCID prefix #1708

Closed duncandewhurst closed 1 month ago

duncandewhurst commented 1 month ago

Closes #1325

duncandewhurst commented 1 month ago

@jpmckinney the lint check is failing on a bunch of ruff errors across various Python files. Should I go through and fix them or do you want to do that in a separate PR?

jpmckinney commented 1 month ago

I already have them fixed locally. I'll commit when reviewing.

jpmckinney commented 1 month ago

Btw, you can now pip install pre-commit and run pre-commit install. The Python and requirements checks will then run if those files are changed.

duncandewhurst commented 1 month ago

Btw, you can now pip install pre-commit and run pre-commit install. The Python and requirements checks will then run if those files are changed.

Great! So to reproduce the GitHub Actions checks locally, the only things I need to run manually are the tests in the standard repo and test_csv.py, test_json.py and test_readme.py from standard-maintenance-scripts?

duncandewhurst commented 1 month ago

@jpmckinney not sure if you were notified of my comment above

duncandewhurst commented 1 month ago

@jpmckinney also, the ruff-format hook makes extensive changes to quotation marks in .manage.py (not sure if anything else) when I change that file.

jpmckinney commented 1 month ago

Ah, yeah, I forgot to run ruff format. We can do that in another PR.

Yes, those are the only tests that are not run automatically by pre-commit.