search

open-contracting / standard

Documentation of the Open Contracting Data Standard (OCDS)
http://standard.open-contracting.org/
Other
136 stars 46 forks source link

Parties should have id and name field required #679

Open kindly opened 6 years ago

kindly commented 6 years ago

As part of the Organization change in 1.1 a new parties list of definition "Organization" was created.

The party list is the only use of the Organization currently. All other fields were migrated to using OrganizationReference. It was definitely decided for OrganizationReference the id should NOT be required for backwards compatibility.

However, for the parties list itself the id should be required otherwise it will give you no way to reference to an organization within it. This would be backwards compatible with 1.0 as the parties list did not exist then.

kindly commented 6 years ago

Pull request #680

jpmckinney commented 6 years ago

1.1 was published a year ago. Although requiring Organization.id would not have been backwards-incompatible at the time, introducing this requirement now could invalidate published 1.1.X data that doesn't have an id set on every Organization. Therefore, I suspect this change would have to be 2.0, in which case we should close the PR.

cc @timgdavies

timgdavies commented 6 years ago

From governance perspective, I think this would have to wait until 2.0.

We could however look at implementing a warning in CoVE in the meantime.

jpmckinney commented 5 years ago

As part of 2.0, we likely want to require name as well, which had been required on OrganizationReference, until we realized this was backwards-incompatible #639.