Closed shimulch closed 3 years ago
@lgp171188 can you take a look at these changes when you have time and see if they make sense? I haven't tested this out.
@shimulch, can you add the task number to the title of this PR? I took a quick look at this and it looks okay. But I still have to test it before approving.
@lgp171188, updated PR title.
This PR changes all occurrence of
theme-colors
function call totheme-color
function call. As there is no such function namedtheme-colors
. Before this PR, compiled versions oflms-main-v1.css
andlms-main-v2.css
had invalid property value for all color-related CSS properties.JIRA tickets: This issue found while working on the following ticket - https://tasks.opencraft.com/browse/BB-3091
~~Discussions: ~~
Dependencies: None
Screenshots:Sandbox URL:Merge deadline: "None"
Testing instructions:
$theme-colors
map. ex - https://getbootstrap.com/docs/4.0/getting-started/theming/#modify-maplms-main-v1.css
andlms-main-v2.css
Author notes and concerns: N/A
Reviewers
Settings