open-craft / edx-simple-theme

GNU Affero General Public License v3.0
3 stars 8 forks source link

[BB-3340] Change theme-colors function call to theme-color #17

Closed shimulch closed 3 years ago

shimulch commented 3 years ago

This PR changes all occurrence of theme-colors function call to theme-color function call. As there is no such function named theme-colors. Before this PR, compiled versions of lms-main-v1.css and lms-main-v2.css had invalid property value for all color-related CSS properties.

JIRA tickets: This issue found while working on the following ticket - https://tasks.opencraft.com/browse/BB-3091

~~Discussions: ~~

Dependencies: None

Screenshots:

Sandbox URL:

Merge deadline: "None"

Testing instructions:

  1. Install this theme on a devstack
  2. Override value of $theme-colors map. ex - https://getbootstrap.com/docs/4.0/getting-started/theming/#modify-map
  3. After compiling sass overridden theme colors should be reflected on lms-main-v1.css and lms-main-v2.css

Author notes and concerns: N/A

Reviewers

giovannicimolin commented 3 years ago

@lgp171188 can you take a look at these changes when you have time and see if they make sense? I haven't tested this out.

lgp171188 commented 3 years ago

@shimulch, can you add the task number to the title of this PR? I took a quick look at this and it looks okay. But I still have to test it before approving.

shimulch commented 3 years ago

@lgp171188, updated PR title.