open-craft / edx-simple-theme

GNU Affero General Public License v3.0
3 stars 8 forks source link

This commit fixes #4 #5

Closed amitvadhel closed 4 years ago

amitvadhel commented 4 years ago

Fixes for link color at bookmark page.

antoviaque commented 4 years ago

@amitvadhel Thank you for your contribution! :)

We will have a look at this - @kaizoku @mtyaka @xitij2000 @pkulkark Can one of you have a look at this as part of the community role?

Note that there is a pending PR from @lgp171188 at https://github.com/open-craft/edx-simple-theme/pull/2 - I'm not sure why it hasn't been merged yet, and he's off this week.

mtyaka commented 4 years ago

Thanks @amitvadhel! I'll take a look in the next couple of days.

mtyaka commented 4 years ago

This works well! I set it up on https://mtyaka.stage.opencraft.hosting/ :+1:

Screenshot 2020-05-14 at 08 29 23

We might want to hold off from merging until @lgp171188 updates us on the status of #2 though.

lgp171188 commented 4 years ago

@mtyaka, I have closed the PR #2 (cf. comment). So this can be merged.

mtyaka commented 4 years ago

@lgp171188 thanks for the update and @amitvadhel thanks for the contribution :)