search

open-craft / ocim-frontend

Frontend Application for OpenCraft Instance Manager
GNU Affero General Public License v3.0
0 stars 0 forks source link

Keep Ocim in one repo? #1

Open antoviaque opened 4 years ago

antoviaque commented 4 years ago

@xitij2000 What's the reason for creating a separate repo for the Ocim frontend? Usually it makes it easier to manage to have all relevant code in a single repository - versions are easier to manage.

CC @bradenmacdonald

bradenmacdonald commented 4 years ago

+1 I much prefer a single repo; just have a backend and frontend folder. It keeps them separated but makes management a lot easier, as a single PR can change the backend and frontend together.

xitij2000 commented 4 years ago

@antoviaque Sure, I will move it to the main OCIM repository. @bradenmacdonald I'm not sure how easy doing that will be at this stage. I will try it but doing so will break all existing PRs, and deployment scripts etc. I don't think we've budgeted for such a refactoring.

bradenmacdonald commented 4 years ago

@xitij2000 What do you mean refactoring? This is a brand new repo. If you mean moving the backend into a backend folder, that's not necessary, but you can still move the frontend into a frontend folder :)

xitij2000 commented 4 years ago

@bradenmacdonald Yup, that's what I meant, moving all backend code to a backend folder. It would be nice but not sure how easy it'd be to accomplish now.

I've gone with just moving the frontend bits to a frontend folder. https://github.com/open-craft/opencraft/pull/484