search

open-craft / xblock-poll

An XBlock for Polling users and displaying the result
GNU Affero General Public License v3.0
18 stars 66 forks source link

[BB-7012] Add github ci workflow and update requirements #100

Closed pkulkark closed 1 year ago

pkulkark commented 1 year ago

Description

This PR removes the circleci workflow and replaces it with github ci. It also updates the requirements, removing python 2.7 and 3.6 support.

Supporting Information

OpenCraft Internal Jira task: BB-7012

Testing Instructions:

Verify that the new github CI tests are all passing and the xblock still functions normally.

pkulkark commented 1 year ago

@Agrendalath I couldn't figure out why, but pytest doesn't seem to work in CI. It fails with some sort of driver errors. And running tests with run_tests seems to fail with an import error related to "ctypes", on my local machine (with the same build environment). So I ended up changing the command for tox to use run_tests so that the CI tests run successfully while keeping pytest for the command make test. Does that make sense?

pkulkark commented 1 year ago

Thanks @Agrendalath. I assume you've tried both pytest as well as the run_tests version. In any case, the error message seems related to the driver. I've created BB-7068 to look into it and fix it. Will move this along.