search

open-craft / xblock-poll

An XBlock for Polling users and displaying the result
GNU Affero General Public License v3.0
18 stars 66 forks source link

Add support for django 4.2 #107

Closed irtazaakram closed 1 year ago

irtazaakram commented 1 year ago

Hi,

This PR is related to ongoing effort to upgrade openedx to Django 4.2

https://github.com/edx/upgrades/issues/368

Please can we have a new release after this PR is merged.

Thanks,

irtazaakram commented 1 year ago

Hi @Agrendalath,

Thank you for the review. I've made some changes in tox that should install Django 4.2 in test env. Also I've updated package versions in requirements.

Thanks,

Agrendalath commented 1 year ago

@irtazaakram, I proposed an alternative approach at https://github.com/open-craft/xblock-poll/pull/108. Would you like to cherry-pick 8d3040b9f4efcdd23ab0177f3d9d32d601a2fc37 into your PR so we can merge it here?

irtazaakram commented 1 year ago

Hi @Agrendalath,

I've updated code as per your approach.

Thanks,

Agrendalath commented 1 year ago

@irtazaakram, please revert the last commit and cherry-pick 8d3040b to ensure all changes are included.

irtazaakram commented 1 year ago

@Agrendalath, I've cherry-picked https://github.com/open-craft/xblock-poll/commit/8d3040b9f4efcdd23ab0177f3d9d32d601a2fc37 into this branch. Please review.