open-craft / xblock-poll

An XBlock for Polling users and displaying the result
GNU Affero General Public License v3.0
17 stars 65 forks source link

Remove `xblock-utils` dependency #114

Open Agrendalath opened 11 months ago

Agrendalath commented 11 months ago

Parent ticket: https://github.com/openedx/axim-engineering/issues/915

This repository is using the xblock-utils package, which has been deprecated and migrated to within the xblock package.

In this ticket, we will:

Example fallback for imports:

try:
    from xblock.utils.resources import ResourceLoader
    from xblock.utils.settings import ThemableXBlockMixin, XBlockWithSettingsMixin
except ModuleNotFoundError:  # For backward compatibility with releases older than Quince.
    from xblockutils.resources import ResourceLoader
    from xblockutils.settings import ThemableXBlockMixin, XBlockWithSettingsMixin
kdmccormick commented 6 months ago

Additional tasks discovered in https://github.com/open-craft/xblock-poll/pull/127, which I had to abandon over time constraints:

kdmccormick commented 3 months ago

@Agrendalath I noticed that 1.14.0 will fix the log warnings--thanks! When the upgrade lands in edx-platform master, assuming it's not risky, would you mind backporting it to Redwood? I think this would be a nice touch to make the release easier for operators to work with.

Agrendalath commented 3 months ago

@kdmccormick, do you mean backporting the version bump to Redwood? Because this XBlock is compatible with all releases back to at least Palm.

kdmccormick commented 3 months ago

@kdmccormick, do you mean backporting the version bump to Redwood?

Yes