search

open-craft / xblock-poll

An XBlock for Polling users and displaying the result
GNU Affero General Public License v3.0
18 stars 66 forks source link

Upgrading repo to be python 3 compliant. #66

Closed adeelkhan closed 4 years ago

adeelkhan commented 5 years ago

This patch would upgrade this repo to be python 3.

adeelkhan commented 5 years ago

@xitij2000 Please review. thanks

xitij2000 commented 5 years ago

@adeelkhan Thanks for this contribution! Is there an existing ticket for this that you can share? I have scheduled this to be reviewed in our next sprint that starts on Tuesday the 22nd of this Month.

adeelkhan commented 4 years ago

@Agrendalath Sorry for a delayed reply. I have replied inline on your questions/suggestions. Please review again. It seems some of the tests show flakiness on travis and either fail on py 2 or 3, so you might need to rerun job as i don't have access rights to do that. On my local machine all tests are passing for py 2 and 3. thanks

Agrendalath commented 4 years ago

Hey @adeelkhan, thank you for addressing the comments! I ran the tests again and scheduled the review for tomorrow.

adeelkhan commented 4 years ago

@Agrendalath Made the changes you suggested. Please review again thanks.

Agrendalath commented 4 years ago

Thank you for addressing the review, @adeelkhan. I'll review this tomorrow.