search

open-craft / xblock-poll

An XBlock for Polling users and displaying the result
GNU Affero General Public License v3.0
18 stars 66 forks source link

MCKIN-12693 Handle updated choice ids in polls #70

Closed moeez96 closed 4 years ago

moeez96 commented 4 years ago

Jira tikcet: https://edx-wiki.atlassian.net/browse/MCKIN-12693 If a choice is updated/added in polls after a user has submitted a response for the old choice, this code crashes since the id for the new choice has changed.

The code crash occurs while generating polls/survey responses.

moeez96 commented 4 years ago

@xitij2000 Please review. Please merge once reviewed and create a release tag. Thanks.

moeez96 commented 4 years ago

@xitij2000 Done. Please review

xitij2000 commented 4 years ago

Note there seem to be some issues with failing tests that aren't related to this PR. I tried to look into them but it seems they are passing locally but failing here. There is a separate ticket to look into them so this is good to go.

mudassir-hafeez commented 4 years ago

@xitij2000 thanks for reviewing this. Can you please create a release tag v1.9.2 as I don't have access for it?

xitij2000 commented 4 years ago

@mudassir-hafeez Could you update the version in setup.py? I would like that to be synced with the tag.

mudassir-hafeez commented 4 years ago

Okay

mudassir-hafeez commented 4 years ago

@xitij2000 version has been updated. Please have a look!

xitij2000 commented 4 years ago

@mudassir-hafeez Merged and tagged.

mudassir-hafeez commented 4 years ago

Thanks @xitij2000