MCKIN-17536: add korean translations

open-craft / xblock-poll

An XBlock for Polling users and displaying the result

GNU Affero General Public License v3.0

17 stars 65 forks source link

MCKIN-17536: add korean translations #77

Closed msaqib52 closed 4 years ago

msaqib52 commented 4 years ago

This PR adds korean translations.

msaqib52 commented 4 years ago

@xitij2000 could you please review this PR?

msaqib52 commented 4 years ago

@taniwha i have updated the PR with suggested changes, Please squash merge the changes and create the release tag if there are no more changes required. Thanks

msaqib52 commented 4 years ago

@taniwha any update on this?

cc: @xitij2000

taniwha commented 4 years ago

@msaqib52 I apologize for the delay. I am having some troubles with testing. I am new on the team and still getting things sorted out. I' did get things mostly up and running (including poll and survey added to a course), but did not see any korean translations. My current assumption is I have done something wrong. Any tips would be greatly appreciated.

xitij2000 commented 4 years ago

@msaqib52 Our new sprint starts tomorrow, so all the translation PRs are scheduled for review in the sprint starting tomorrow.

taniwha commented 4 years ago

:+1:

[x] I tested this: Ensured displayed buttons showed translated text (looked like Korean)
[x] I read through the code
[ ] I checked for accessibility issues
[ ] Includes documentation
[ ] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.