search

open-craft / xblock-poll

An XBlock for Polling users and displaying the result
GNU Affero General Public License v3.0
17 stars 65 forks source link

[BD-29] [TNL-6993] [BB-2706] Make Poll and Survey Indexable #81

Closed ahmedbilal closed 4 years ago

ahmedbilal commented 4 years ago

Make Poll and Survey Indexable

JIRA tickets:

Merge deadline: "None"

Testing instructions:

  1. Clone this repo in src directory of your devstacks.
  2. Checkout this branch i.e ahmed/bb-2706-make-poll-and-survey-indexable
  3. Install the cloned project into both LMS and Studio by changing your directory to the src/xblock-poll directory in your devstack and executing pip install -e .
  4. Add poll and survey to the Advanced Module List. See https://github.com/open-craft/xblock-poll#setting-up-a-course-to-use-polls-and-surveys
  5. Create two blocks. One poll and other survey.
  6. Reindex your course.
  7. Go to LMS and search for some string that appears in the poll or survey

Reviewers

ahmedbilal commented 4 years ago

@xitij2000 Can you take a look at failed CI error? I don't think it is related.

xitij2000 commented 4 years ago

@ahmedbilal You can always log into the CI and rerun the failed tests. I've done so and merged the PR.

ahmedbilal commented 4 years ago

@xitij2000 I didn't know that. Thanks for tip :+1:

lgp171188 commented 4 years ago

@ahmedbilal, @xitij2000, since a new tag/release was not created after this change was merged, I have requested @shimulch to merge https://github.com/open-craft/xblock-poll/pull/83 with the same version and tag a new release 1.10.0 including that change as well. FYI.