search

open-craft / xblock-poll

An XBlock for Polling users and displaying the result
GNU Affero General Public License v3.0
17 stars 65 forks source link

[BB-2683] Add python 3.8 support #83

Closed shimulch closed 4 years ago

shimulch commented 4 years ago

Updated dependencies to support python 3.8 & django 2.2, while keep support on python 2.7 & django 1.11

lgp171188 commented 4 years ago

@shimulch, the changes look good to me and the CI checks are passing. I will test this in the devstack and approve this PR after verifying that the XBlock works okay on the devstack.

lgp171188 commented 4 years ago

@shimulch, someone already upgraded the version in setup.py to 1.10.0 but missed creating a tag/release. So I'd say we can use the same version as-is, and tag a new 1.10.0 release including this change. See this comment.

xitij2000 commented 4 years ago

I think 1.10 makes sense. If this dropped Python 2 then a v2 would be warranted.

shimulch commented 4 years ago

Merged & Released - https://github.com/open-craft/xblock-poll/releases/tag/v1.10.0