search

open-craft / xblock-vectordraw

An XBlock for creating vector drawing exercises
GNU Affero General Public License v3.0
2 stars 3 forks source link

Possible bug - scores not in progress page before submission - missing max_score() method #21

Open taniwallach opened 2 years ago

taniwallach commented 2 years ago

The XBlock does not have a max_score method. AFAIK a scorable Xblock must have such a method.

When I first set up a vector draw problem (on a system still running Ginkgo with many patches, and with persistent grading enabled) - the progress page showed "No problem scores in this section". Only after a submission did a score appear.

See:

BTW - maybe the XBlock should inherit from ScorableXBlockMixin.

bradenmacdonald commented 2 years ago

Hi @taniwallach, thanks for the report. As we don't have any customers using this XBlock right now, our maintenance of it is limited to ensuring it still installs. If you'd like to submit a PR to fix any bugs or implement any features, we'd be happy to review it though.