On touch devices, drawing a vector also scrolls

open-craft / xblock-vectordraw

An XBlock for creating vector drawing exercises

GNU Affero General Public License v3.0

2 stars 3 forks source link

On touch devices, drawing a vector also scrolls #6

Closed ChristopherChudzicki closed 7 years ago

ChristopherChudzicki commented 8 years ago

@bradenmacdonald @dseaton @antoviaque

On touchscreens, drawing a new vector also scrolls.

This does not happen when dragging or repositioning a vector, only when drawing a new vector (i.e., when drawMode=true).

See example (note drawMode is currently broken for first vector, so need to test on second vector.)

itsjeyd commented 7 years ago

@bradenmacdonald I think we fixed this via #12? If so, we should probably close this issue :)

(I know we're not working on Vector Drawing ATM; was cleaning up some old notifications in my inbox when I came across this issue.)

ChristopherChudzicki commented 7 years ago

@itsjeyd I know this was fixed in the jsinput version; I do not follow the X-Block version as closely. Was it fixed in X-Block?

itsjeyd commented 7 years ago

Thanks for the reply, @ChristopherChudzicki. I had a closer look, and #12 seems to be a straightforward port of https://github.com/open-craft/jsinput-vectordraw/pull/31. So I'm assuming the problem has been fixed for the XBlock version. Closing this issue, but let me know if you have any objections.