search

open-dicom / dicom_parser

Facilitates DICOM data access.
https://dicom-parser.readthedocs.io/en/latest/?badge=latest
MIT License
26 stars 15 forks source link

Fix phase encoding property #81

Closed ZviBaratz closed 2 years ago

ZviBaratz commented 3 years ago

The current implementation is experimental (i.e. I am still trying to figure out how to translate the spatial information in the header to AP/PA/LR/RL labels that can used to generate BIDS-compatible relative paths).

ZviBaratz commented 2 years ago

@magerkurth I actually ended up simply encoding it as FWD and REV (see this discourse discussion) which seems to work well enough. I'm definitely not against fixing it up to provide AP/PA/RL/LR labels, but I'm not entirely convinced it's necessary.

magerkurth commented 2 years ago

Siemens encodes the direction in AP/PA/RL/LR on the Syngo GUI and if I am not wrong also in the PDF printout of the protocol. It would be a nice feature to match, but I agree may not be essential. However, I use your tool to generate PDFs with the most relevant values, to avoid generating PDFs from the console for researchers over and over again. For non physicist AP/PA/RL/LR would be easier to understand.

ZviBaratz commented 2 years ago

That makes sense. So glad to hear you find it useful. Please feel free to PR if you have an implementation in mind, I got a little lost trying to come up with something.

ZviBaratz commented 2 years ago

Since the FWD/REV solves the original issue, which was to create BIDS-compatible paths, I'm closing this for now. If directional labels are, in fact, required, a new issue will be opened for that purpose.

magerkurth commented 2 years ago

I have a lock I get on with the current possibilities of the code and discuss it further in at our lab. Thanks a lot for your quick answers.