search

open-dicom / dicom_parser

Facilitates DICOM data access.
https://dicom-parser.readthedocs.io/en/latest/?badge=latest
MIT License
26 stars 15 forks source link

New release? Jupyter-lab broken with pinned Jinja2 #87

Closed matthew-brett closed 2 years ago

matthew-brett commented 2 years ago

Would you consider making a new release?

I just pip-installed Dicom_parser, and JupyterLab, and this gave me a broken JupyterLab:

$ mkvirtualenv test
$ pip install jupyterlab
$ pip install dicom_parser

This ends with output:

Installing collected packages: numpy, pydicom, pandas, nibabel, jinja2, dicom-parser
  Attempting uninstall: jinja2
    Found existing installation: Jinja2 3.0.3
    Uninstalling Jinja2-3.0.3:
      Successfully uninstalled Jinja2-3.0.3
Successfully installed dicom-parser-1.1.1 jinja2-2.11.3 nibabel-3.2.2 numpy-1.22.2 pandas-1.4.1 pydicom-2.1.2

Notice the downgrade of Jinja. Next:

$ jupyter-lab

Gives:

[snip]
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/Volumes/zorg/mb312/.virtualenvs/test/lib/python3.8/site-packages/markupsafe/__init__.py)

Web search gives this thread, which suggests:

pip install -U jinja2

Sure enough, this fixes it.

Repeating these steps, but installing from latest Master locally, does not downgrade Jinja2, and does not cause this error.

Maybe a new release would prevent this error?

ZviBaratz commented 2 years ago

Certainly. Do you think I should wait until we merge the existing PR or just go for it?

matthew-brett commented 2 years ago

Maybe just release as is, so the PR has time to settle after it gets merged.

On Sat, 19 Feb 2022, 14:43 Zvi Baratz, @.***> wrote:

Certainly. Do you think I should wait until we merge the existing PR or just go for it?

— Reply to this email directly, view it on GitHub https://github.com/open-dicom/dicom_parser/issues/87#issuecomment-1046033513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQQHHXVPUBEYPNWOQ3C63U36UAJANCNFSM5O2O43QQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

ZviBaratz commented 2 years ago

Published v1.2.0.