search

open-dict-data / ipa-dict

Monolingual wordlists with pronunciation information in IPA
https://open-dict-data.github.io/ipa-lookup/
MIT License
555 stars 86 forks source link

Adding as a node package #18

Open Kotarski opened 4 years ago

Kotarski commented 4 years ago

I've been working on a fork to wrap this in javascript to make it into an NPM package (https://github.com/Kotarski/ipa-dict).

Is this something that could be pulled or should I keep it as a fork?

Are you happy for me to submit this to NPM as ipa-dict?

Thanks,

dohliam commented 4 years ago

Hi @Kotarski thanks for working on this! Sounds like a great idea to have this available on NPM. The only thing would be keeping it up to date -- there are quite a few issues with some of the experimental data (e.g., in nb, yue, zh) that will be corrected in upcoming commits. Would it be fairly easy to pull those in (perhaps automatically?) when the repo updates?

Kotarski commented 4 years ago

@dohliam

It should be just a case of pulling the new version as it's just a repo inside. Not sure how I'd go about doing it automatically at the moment but can look into it... maybe the new git workflow stuff will help. Still a bit of work to be done, but I'll continue once I'm back from holiday!

Kotarski commented 3 years ago

I've finally got around to actually doing this over the holidays (https://www.npmjs.com/package/ipa-dict). I've set it up so everything is generated from the data files, so just a pull and republish will update it.

Should we pull the fork back into the main repo, or leave it separate? One benefit of merging it back in is that it could automatically publish when the data changes, but I don't mind.