search

open-dis / open-dis-cpp

C++ implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7
BSD 2-Clause "Simplified" License
91 stars 66 forks source link

Transmitter PDU has been copied from DIS 6 to DIS 7 folder. #55

Closed semihkurt closed 3 years ago

semihkurt commented 3 years ago

Only changes have been made:

As I see TransmitterPDU is not deprecated on DIS 7 and it exists on Java repository. I've copied exactly the same file which was on dis6 to dis7 folder. After that to be able to compile the project , I've changed RadioEntityType has been changed to RadioType. Then, there is a new class in DIS 7 called as AntennaLocation which contains relativeAntennaLocation and antennaLocation inside of it so I used that new class and made changes accordingly.

There might be new updates if you can validate whether DIS v6 versus v7 this document is valid because I've exactly copied TransmitterPdu from DIS 6 which may not cover new updates.

semihkurt commented 3 years ago

Although it works fine, it is not finished fully. After I finish it completely, I will open new pull request.

leif81 commented 3 years ago

Ok no problem. In future if you want you can mark the PR as a "draft" and repeatedly push commits to it until you're happy with it and then when ready for review take the draft status off. Closing and opening a new one later is fine too. https://github.blog/2019-02-14-introducing-draft-pull-requests/

semihkurt commented 3 years ago

Ohh thanks, that's a really cool feature which I wasn't aware of it :) Appreciated!