search

open-dis / open-dis-cpp

C++ implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7
BSD 2-Clause "Simplified" License
91 stars 66 forks source link

Add open-dis-cpp to vcpkg #63

Closed leonardooyama closed 1 year ago

leonardooyama commented 3 years ago

What about including the port of open-dis-cpp tp vcpkg (https://github.com/microsoft/vcpkg#contributing)?

leif81 commented 2 years ago

@leonardooyama I like this idea a lot but I don't yet know how much effort it'll be. Have you experience?

leonardooyama commented 2 years ago

Will learn about it.

wadehunk commented 1 year ago

I'm also interested in getting open-dis submitted to the Conan Center repository as well. I've got contributor permissions there and hope to get it integrated, but they require access to immutable source code packages. Could also look into vcpkg. Both would require creating a tagged release version on github to reference. See #75 . I have my own selfish purposes for this, but I think this would also open up potential wider use of open-dis.

leif81 commented 1 year ago

@wadehunk I think this is a good idea. Is there anything special we need to do to do to the code base to prepare or is all we need a tagged release tarball? e.g. open-dis-cpp-1.0.0.tar.gz

wadehunk commented 1 year ago

@leif81 I've got a draft conan recipe that I can get submitted to the Conan Center repository, just need a tagged release. I'm less familiar with vcpkg, but I'm pretty sure it's a very similar process.

leonardooyama commented 1 year ago

Nop. I am only a OpenDIS and vcpkg user. I don't have much expertise in CMAKE, which I believe is required for including a project in vcpkg.

On Thu, Nov 18, 2021, 18:42 Leif Gruenwoldt @.***> wrote:

@leonardooyama https://github.com/leonardooyama I like this idea a lot but I don't yet know how much effort it'll be. Have you experience?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/open-dis/open-dis-cpp/issues/63#issuecomment-973295479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRUXNBX72LNQ2S46IHWKE3UMVXL5ANCNFSM5ECJCYYA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

wadehunk commented 1 year ago

Looked into creating a vcpkg port and it actually looks easier than conan. I will get one submitted as soon as there is a release.

leif81 commented 1 year ago

I've created a separate issue to track publishing a conan package #77

Am thinking that based on interest we can publish as a vcpkg or conan or both.

wadehunk commented 1 year ago

VCPkg PR: microsoft/vcpkg#29472 Once a release is tagged, can update and mark as ready.

leif81 commented 1 year ago

@wadehunk I've tagged a v1.0.0 release

leif81 commented 1 year ago

Woops I guess we'll need a 1.0.1 release. ref #78. No biggie, give me a few minutes.

leif81 commented 1 year ago

@wadehunk I've tagged a new release v1.0.1 that includes #78 . Over to you

leonardooyama commented 1 year ago

These are great news! Thank you so much!

On Tue, Feb 7, 2023, 00:49 Leif Gruenwoldt @.***> wrote:

@wadehunk https://github.com/wadehunk I've tagged a new release v1.0.1 that includes #78 https://github.com/open-dis/open-dis-cpp/pull/78 . Over to you

— Reply to this email directly, view it on GitHub https://github.com/open-dis/open-dis-cpp/issues/63#issuecomment-1420159125, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRUXNCS7MIVTASPTYV6OCTWWHA55ANCNFSM5ECJCYYA . You are receiving this because you were mentioned.Message ID: @.***>

wadehunk commented 1 year ago

PR microsoft/vcpkg#29472 has been merged! open-dis-cpp should be available via VCPkg as soon as it propagates through the CDN.

leif81 commented 1 year ago

@wadehunk I could be looking in the wrong spot but have you seen the open-dis-cpp appear in vcpkg yet? When I query for it I don't see it yet. https://vcpkg.io/en/packages.html

wadehunk commented 1 year ago

@leif81 That index must not get updated often. Seems like it has listed 2022 total packages for a while now. The latest release notes open-dis-cpp as 1 of 47 new ports added: https://github.com/microsoft/vcpkg/releases/tag/2023.02.24

Maybe it will eventually show up there.

leonardooyama commented 1 year ago

If you clone the vcpkg project to your PC, you have to run the bootstrap-vcpkg.bat using cmd or PowerShell. After this, you just have to run "vcpkg install open-dis-cpp:x64-windows". If you want to export the library to use into other environments, like I do with Qt Creator, just run "vcpkg export open-dis-cpp --zip". It will generate a zip file with your library compiled. The good thing about this is that you can easily generate your binaries with your compiler version. Let's say, you can be using either VS 2019 or VS 2022. You will get all binaries and dependencies ready to use. Other good libraries are in vcpkg as well, such as GDAL and GeographicLib (good library to convert to/from MGRS and lat/long and calculate geodesic lines).

leonardooyama commented 1 year ago

Open-Dis-Cpp is officially into vcpkg. Thanks!