search

open-dis / open-dis-cpp

C++ implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7
BSD 2-Clause "Simplified" License
90 stars 65 forks source link

One byte chunk refactor #81

Closed crhowell3 closed 1 year ago

crhowell3 commented 1 year ago

I believe I have completed the refactor, successfully removing the OneByteChunk wrapper class and instead using native uint8_t types in its place. I was able to successfully build the dis6 and dis7 libraries using CMake. Ping me if there is anything I need to adjust before this gets merged in.

crhowell3 commented 1 year ago

Made a small change to now include the appropriate header for the introduction of the uint8_t types. This PR is still good for merge, pending review.

crhowell3 commented 1 year ago

Not to rush, but is there a current time table for this change getting merged in? This change would be beneficial to some things we are working on that leverage this library.

leif81 commented 1 year ago

Hi @crhowell3 I should be able to take a look later this evening. If I have no questions I'll merge right away.

leif81 commented 1 year ago

Thank-you @crhowell3 , really good change!

The only comment I have is the formatting changes included in the PR made it a little tough to review the one byte chunk portion of the PR. It would just be easier next time if the formatting was in a different PR from the logic change.

Thank-you again!