search

open-dis / open-dis-cpp

C++ implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7
BSD 2-Clause "Simplified" License
90 stars 65 forks source link

Modernize code base #83

Open crhowell3 opened 1 year ago

crhowell3 commented 1 year ago

I want to take one more look over everything before I mark this as ready, but I have completed the bulk of the code base overhaul. I have included .clang-format and .clang-tidy configuration files in the top-level directory, and I ran clang-tidy and Google's cpplint on all the source files to reformat them to follow Google Style conventions. I changed a lot of the primitive types to use the modern, standardized uint_t/int_t types defined in <cstdint>, i.e., unsigned int -> uint32_t, etc. I also changed all the DIS includes to use "" instead of <>, as is convention for project-level include files.

Again, there may be a few other things I need to tweak before this is ready, but I just wanted to go ahead and create the PR with my current progress.

crhowell3 commented 1 year ago

Also, this will resolve issue #52.

leif81 commented 1 year ago

@crhowell3 this PR is marked draft. Did you have further changes you planned to add here?

crhowell3 commented 8 months ago

I will take another look at this issue to ensure that everything is ready as I intended. I will let you know if there is anything else that needs to be done. Sorry for such a long wait