Closed phoppermann closed 10 months ago
Thanks @phoppermann
The way you've done it makes sense to me. I think it's about time we move towards a single dis code base, given dis 7 is backwards compat with 6. Getting there will take a big effort though making sure the dis 6 fixes get forward ported onto the dis 7 PDUs which in manu cases were affected by the same code generator bugs. Baby steps.
Note: it's not clear to me how you plan to handle the enum for DIS 6/7 (there's no
PDUType.h
indis7
). Currently, I've added everything as a superset such that the different versions share the same enum. If you prefer duplicating the header, feel free to change the PR as you desire.