Fire PDU Attributes incorrect

open-dis / open-dis-java

Java implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7 :boom:

Other

44 stars 35 forks source link

Fire PDU Attributes incorrect #137

Closed mmyer027 closed 7 months ago

mmyer027 commented 7 months ago

Fire PDU has two incorrect fields/attributes according to the DIS 1278.1-2012 spec.

EventId: -- According to the DISv7 spec EventId is a Site/Application/Entity field. However in the DISv7 Fire PDU EventId is an EventIdentifier rather than an EntityID like Firing Entity ID, Target Entity ID, and Munition/Expendable Entity ID.
Descriptor: -- Descriptor for DISv7 should be similar to DISv6 Descriptor. However the DISv7 Descriptor is an empty class with default constructor. See: edu.nps.moves.disv7.Descriptor.

mmyer027 commented 7 months ago

I may be incorrect about the descriptor in that you need to use either MunitionDescriptor/ExpendableDescriptor and then cast it, but I believe this is still an issue with EventId

leif81 commented 7 months ago

Thanks @mmyer027 , would you be interested in submitting a pull request for the EventId fix?

mmyer027 commented 7 months ago

Sure @leif81 I think I can do that.

I believe there is also an issue with the fireTypeIndicator accessor. Is there a way you can check this? There appears to be an accessor but no mutator. If you could verify I will create an issue for this as well.

mmyer027 commented 7 months ago

figured out my issue with the fireTypeIndicator. It had to do with not setting the PDU status correctly. I submitted a pull request for the EntityId issue however.